This seems excellent to me. (I can't say anything else as I was calling for this before
) As I understand it, to the user all different mysql versions disapear in the future? I must admit I did not test it, but reading the changes it looks like a very good start.
Some remarks :
- Not so smart to include the indonesion translations at once. I can manage that, however.
- You added the 'SConnect2Server' constant only to indonesian version. I can manage that as well, but don't know yet if I'll do that. Are all logged messages localized?
- When using the deprecated versions it's not so bad to use the Mysql structures. (They'll probably be dropped after next official release) For the other mysql versions (that's outside the ifdefs) you MUST use the corresponding library functions. (To get rid once and for ever of these ever changing structures)
- Do you think it would be possible to keep the different protocols as choice and check first if the libmysqlxx.dll's exist in case the user chooses one?
- Very close to previous remark : what about embedded mysql? Maybe same solution as we used in the old version? Subclassing your Plaindriver?
- Do you think we could remove all old stuff, as now you duplicated a lot to avoid breaking our version, which we appreciate very much.
- Don't be angry if we only accept this change after next official production release (whatever number that will be). We're trying to freeze current version, because we want to start a real beta test period. (and a release afterwards).
@fduenas, @michael, @zippo, @others
What do you think of this as a concept, details are not important yet. I support it for the release after the next one.
If we agree on adding:
Should we add it to SVN now with the 'ENABLE_MYSQL_NEW_DRIVER' NOT defined in Zeos.inc? This gives us (and other users) the possibility to play with it already. And tohenk doesn't have to keep his new version updated himself.